Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the java compiler version be unified as 1.8 or newer #8705

Closed
letuer opened this issue Nov 13, 2021 · 2 comments
Closed

Should the java compiler version be unified as 1.8 or newer #8705

letuer opened this issue Nov 13, 2021 · 2 comments
Labels

Comments

@letuer
Copy link

letuer commented Nov 13, 2021

There is two java compiler version in master branch,1.7 and 1.8.
image

Should we upgarde it to 1.8 or newer. For the following reasons:

  1. Java8 and 11 is most popular Java version。Few applications still use Java7。 See 2020-java-technology-report.
  2. Java8 new features, like lambda、stream,can improve development efficiency, make code implementation cleaner。

Please think about it. Thanks.

@ejona86
Copy link
Member

ejona86 commented Nov 15, 2021

Duplicate of #4671.

Note that there is nothing to "unify" here. The 1.8s you see there are all Android, which can do language desugaring for older platforms but isn't actually Java 8 (e.g., stream is not available; although there is also some library desugaring available). But why it is needed is because of some fallout from Guava warning about dropping Java 7 support (see https://github.com/grpc/grpc-java/releases/tag/v1.38.0 and https://github.com/google/guava/releases/tag/v30.1).

@ejona86 ejona86 closed this as completed Nov 15, 2021
@letuer
Copy link
Author

letuer commented Nov 15, 2021

Thanks, I get it. If not necessary, compatibility for older platforms is more important.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants