core: enable retry by default #8402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
added
the
TODO:backport
dapengzhang0
commented
Aug 11, 2021
core/src/test/java/io/grpc/internal/ManagedChannelImplTest.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Aug 11, 2021
Done. |
dapengzhang0
added a commit
to dapengzhang0/grpc-java
that referenced
this pull request
Aug 12, 2021
Stabilize `enableRetry()` and `disableRetry()`. Disable retry in `ManagedChannelImplTest` because each call attempt will fork the headers to a new instance, and add a ClientStreamTracer.Factory for bufferSizeLimit in CallOptions, which makes verification not straightforward.
dapengzhang0
removed
the
TODO:backport
dapengzhang0
added a commit
that referenced
this pull request
Aug 12, 2021
Stabilize `enableRetry()` and `disableRetry()`. Disable retry in `ManagedChannelImplTest` because each call attempt will fork the headers to a new instance, and add a ClientStreamTracer.Factory for bufferSizeLimit in CallOptions, which makes verification not straightforward.
|
Addressing #3982 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilize
enableRetry()anddisableRetry().Disable retry in
ManagedChannelImplTestbecause each call attempt will fork the headers to a new instance, and add a ClientStreamTracer.Factory for bufferSizeLimit in CallOptions, which makes verification not straightforward.