Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for s390x (s390_64) machine architecture #8191

Closed
joschi opened this issue May 20, 2021 · 6 comments
Closed

Support for s390x (s390_64) machine architecture #8191

joschi opened this issue May 20, 2021 · 6 comments
Milestone

Comments

@joschi
Copy link

joschi commented May 20, 2021

Is your feature request related to a problem?

The protobuf compiler protoc supports a few non-x86 machine architectures such as aarch64, ppcle, and s390x which are not supported by the gRPC plugin protoc-gen-grpc-java:
protoc - supported architectures

Describe the solution you'd like

It would be great if gRPC-Java supported the same machine architectures as Protocol Buffers out of the box.

With aarch64 there's already a non-x86 architecture supported by gRPC-Java and maybe support for the other machine architectures could be implemented in the same way.

@sanjaypujare
Copy link
Contributor

It would be great if gRPC-Java supported the same machine architectures as Protocol Buffers out of the box.

I suspect it is going to be demand based as opposed to just matching the Protocol Buffers functionality. Is there a pointer to what specific changes are needed to support s390x? You could also contribute a PR to add that support.

@joschi
Copy link
Author

joschi commented May 20, 2021

Is there a pointer to what specific changes are needed to support s390x? You could also contribute a PR to add that support.

Unfortunately I neither have experience with the s390x architecture nor do I know exactly what would have to be changed specifically in gRPC-Java.

My naive assumption is that a similar approach like the one taken for aarch64 support might work:
#6441

@ejona86
Copy link
Member

ejona86 commented May 26, 2021

We tend to have these other architectures be user contributions because we can't test them. So if you contribute a change, at least we know it works for one user.

@ejona86 ejona86 added this to the Unscheduled milestone Jun 1, 2021
@kiwi1969
Copy link
Contributor

Since sept 2020 grpcjava works on IBM JVM using IBMJSEE2 on S390x with pull #7422

Is the issue here now resolved?

@ejona86
Copy link
Member

ejona86 commented Sep 29, 2022

This issue is about protoc binaries for running the build on an s390x machine. With #7422 you can compile on another machine easily and deploy on s390x, but it is still annoying to run protoc as part of the build.

@ejona86
Copy link
Member

ejona86 commented Apr 6, 2023

Fixed by #9455

@ejona86 ejona86 closed this as completed Apr 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants