xds: add null reference checks in SslContextProviderSupplier #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjaypujare
added
the
TODO:backport
| } | ||
|
|
||
| @Test | ||
| public void get_updateSecret() { | ||
| prepareSupplier(); | ||
| prepareSupplier(true); |
There was a problem hiding this comment.
I would suggest use two separate methods:
prepareSupplier();
updateSslContext();
The boolean arg true looks less readable.
dapengzhang0
approved these changes
May 12, 2021
sanjaypujare
added a commit
to sanjaypujare/grpc-java
that referenced
this pull request
May 12, 2021
sanjaypujare
added a commit
that referenced
this pull request
May 12, 2021
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null checks in SslContextProviderSupplier constructor and
close(in caseupdateSslContextwas never called)