Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Fix validation of HCM filter and Router httpFilter #8039

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

sanjaypujare
Copy link
Contributor

  • Don't enforce a specific name-match for HCM and Router httpFilter
  • Don't allow "managed-mtls" in the application-protocols

CC @ejona86

@sanjaypujare
Copy link
Contributor Author

ping...

Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanjaypujare sanjaypujare merged commit d9956a5 into grpc:master Apr 2, 2021
@sanjaypujare sanjaypujare deleted the filter-check-fix branch April 2, 2021 16:48
sanjaypujare added a commit to sanjaypujare/grpc-java that referenced this pull request Apr 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants