interop-testing: add fake altsHandshakerService for test #7847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interop-testing/src/main/java/io/grpc/testing/integration/TestServiceClient.java
Outdated
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/AltsHandshakerTestService.java
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/TestServiceClient.java
Outdated
Show resolved
Hide resolved
interop-testing/src/test/java/io/grpc/testing/integration/AltsHandshakerTest.java
Outdated
Show resolved
Hide resolved
interop-testing/src/test/java/io/grpc/testing/integration/AltsHandshakerTest.java
Outdated
Show resolved
Hide resolved
| private void startAltsServer() throws Exception { | ||
| executor = Executors.newSingleThreadScheduledExecutor(); | ||
| ServerCredentials serverCreds = AltsServerCredentials.newBuilder() | ||
| private Server registerTestServer() { |
There was a problem hiding this comment.
Actually you can still use void startAltsServer(), only change in the old code needed is testServer = grpcCleanup.register(.....).start(); Registering is only a small step and does not deserve a method name.
dapengzhang0
approved these changes
Jan 28, 2021
YifeiZhuang
requested review from
dapengzhang0
and removed request for
dapengzhang0
interop-testing/src/main/java/io/grpc/testing/integration/AltsHandshakerTestService.java
Show resolved
Hide resolved
dapengzhang0
approved these changes
Feb 10, 2021
This was referenced Feb 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.