grpclb: keep RR Subchannel state in TRANSIENT_FAILURE until becoming READY #7816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…READY If all RR servers are unhealthy, it's possible that at least one connection is CONNECTING at every moment which causes RR to stay in CONNECTING. It's better to keep the TRANSIENT_FAILURE state in that case so that fail-fast RPCs can fail fast. The same changes have been made for RoundRobinLoadBalancer in grpc#6657
ejona86
approved these changes
Jan 15, 2021
voidzcy
reviewed
Mar 11, 2021
| // Switch subchannel1 to TRANSIENT_FAILURE, making the general state TRANSIENT_FAILURE too. | ||
| Status error = Status.UNAVAILABLE.withDescription("error1"); | ||
| deliverSubchannelState(subchannel1, ConnectivityStateInfo.forTransientFailure(error)); | ||
| inOrder.verify(helper).updateBalancingState(eq(TRANSIENT_FAILURE), pickerCaptor.capture()); |
There was a problem hiding this comment.
This test is weird. subchannel2 is still connecting, so the overall state should be CONNECTING. This is mostly because subchannels with CONNECTING state are ignored when aggregating the overall state.
So, observing TRANSIENT_FAILURE isn't related to your change. And I believe that should be fixed. However, for this test case specifically, you should bring all subchannels into TRANSIENT_FAILURE and then perform the test for behaviors related to your change.
There was a problem hiding this comment.
It looks like we should stop ignoring CONNECTING with this change (and use the same logic as RR and elsewhere)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all RR servers are unhealthy, it's possible that at least one
connection is CONNECTING at every moment which causes RR to stay in
CONNECTING. It's better to keep the TRANSIENT_FAILURE state in that
case so that fail-fast RPCs can fail fast.
The same changes have been made for RoundRobinLoadBalancer in #6657