core: delay CallCredentialsApplyingTransport shutdown until metadataApplier finalized #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llCredentialsTransport
YifeiZhuang
changed the title
ejona86
reviewed
Jan 16, 2021
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Jan 19, 2021
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Show resolved
Hide resolved
ejona86
reviewed
Jan 21, 2021
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Jan 21, 2021
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Show resolved
Hide resolved
YifeiZhuang
changed the title
ejona86
reviewed
Jan 21, 2021
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Show resolved
Hide resolved
ejona86
approved these changes
Jan 21, 2021
core/src/main/java/io/grpc/internal/CallCredentialsApplyingTransportFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #7797
Add counter to track pending metadataApplier streams, and add callback upon completion to notify callCredentialsTransport and properly terminate a
CallCredentialsApplyingTransport. Verified that #7797 seems fixed.