api: delete LoadBalancer.Helper APIs that had been deprecated for a long time #7793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should migrate them before merging this PR. |
voidzcy
force-pushed
the
impl/delete_deprecated_lb_helper_apis
branch
from
56e759b
to
94b1cae
Compare
…eprecated_lb_helper_apis
voidzcy
force-pushed
the
impl/delete_deprecated_lb_helper_apis
branch
from
94b1cae
to
01163e6
Compare
dapengzhang0
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete a bunch of old LoadBalancer.Helper APIs that had been deprecated for a long time.
createSubchannel(EquivalentAddressGroup addrs, Attributes attrs)createSubchannel(List<EquivalentAddressGroup> addrs, Attributes attrs)Deprecated in api: pass Subchannel state updates to SubchannelStateListener rather than LoadBalancer (take 2) #5722 (v1.22)
updateSubchannelAddresses(Subchannel subchannel, EquivalentAddressGroup addrs)updateSubchannelAddresses(Subchannel subchannel, List<EquivalentAddressGroup> addrs)Deprecated in api: deprecate Helper.updateSubchannelAddresses() and add equivalent on Subchannel #5802 (v1.22)
These deprecated APIs has stronger implementation requirement for synchronization as they originally did not require invocations to be from the SynchronizationContext (although a logged warning was added later if detected the call is not from the SynchronizationContext). Their replacements relaxed the burden for implementations to be thread-safe and would throw if calls are not from the SynchronizationContext.
Other old deprecated APIs are:
runSerialized(Runnable task): deprecated in core: SynchronizationContext exposed by LoadBalancer.Helper #4971 (v1.17)getNameResolverFactory(): deprecated in core: deprecate LoadBalancer.Helper#getNameResolverFactory #5418 (1.20.0)TODO: will need to migrate internal usages.