android, cronet, android-interop-testing: bump Android versions #7740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing deprecated NetworkInfo API, which is intended for supporting old API version; migrate to androidX.
…oidX, bump its corresponding dependency versions.
voidzcy
force-pushed
the
bugfix/bump_android_sdk_versions
branch
from
2f1ea10
to
dbc6c28
Compare
…notation to emulate Android 28 for cronet tests.
…ing deprecated NetworkInfo API, which is intended for supporting old API version; migrate to androidX.
…oidX, bump its corresponding dependency versions.
ejona86
reviewed
Dec 29, 2020
…/grpc-java into bugfix/bump_android_sdk_versions
|
Note after this change, you may still see tons of in android-interop-testing. Those are hard to fix. The message doesn't give any clue for where the source code is. Will fix it separately. |
Yeah, I had seen that already. I think google/error-prone#1981 is related, although not the exact same trigger. I think I tracked it down to the gRPC generated code, but couldn't figure out why our filters weren't excluding it from checking. |
ejona86
approved these changes
Dec 29, 2020
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
…#7740) Bumps target SDK version of grpc-android, grpc-cronet, grpc-android-interop-testing to API 29. Major related changes are: - Migrated android.support to androidx, which is required for Android Q. - android.net.NetworkInfo is deprecated in SDK 29, suppressed compiler warnings as it is needed for supporting old Android versions. - Robolectric requires Java 9+ for Android 29, which causes unit tests in grpc-cronet fail. Added annotation to emulate Android 28 for grpc-cronet's test. - Upgraded Android dependencies accordingly in android-interop-testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump target SDK version of grpc-android, grpc-cronet, grpc-android-interop-testing to API 29. Resolves #7439.
android.supporttoandroidx, which is required for Android Q.android.net.NetworkInfois deprecated in SDK 29, suppressed compiler warnings as it is needed for supporting old Android versions.This is also a partial fix for #7734 (grpc-android and grpc-cronet should be clean now, android-interop-testing still has some code lint issues need to be fixed). Also, android examples are not updated.