stub: avoid race in onHalfClose server StreamObserver #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ejona86
approved these changes
Jul 19, 2019
ejona86
requested changes
Jul 19, 2019
| @@ -171,7 +172,7 @@ public void onHalfClose() { | |||
| method.invoke(request, responseObserver); | |||
| request = null; | |||
| responseObserver.freeze(); | |||
| if (call.isReady()) { | |||
| if (!wasReady) { | |||
There was a problem hiding this comment.
This is inverted. It should be if (wasReady)
There was a problem hiding this comment.
Oh, I thought you said onReady should only be called once, and it was which ever method (onHalfClose or onReady) was invoked first. Is that not correct?
There was a problem hiding this comment.
Before onHalfClose(), onReadyHandler == null. So if there was an onReady callback, the code "ignored" it. The onReady() callback will generally happen before onHalfClose(). This check was to "replay" that missed onReady call.
There was a problem hiding this comment.
I see, updated.
ejona86
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.