core: fix terminated status check in TransportListener #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
internally tracked bug b/136496833 |
ejona86
reviewed
Jul 8, 2019
ejona86
reviewed
Jul 9, 2019
core/src/test/java/io/grpc/internal/InternalSubchannelTest.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Jul 9, 2019
core/src/test/java/io/grpc/internal/InternalSubchannelTest.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Jul 9, 2019
creamsoup
added a commit
that referenced
this pull request
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we queue and execute the runnable in transport terminated, it may not be drained immediately if there's a already drain is running on the other thread.
Adding a boolean to check shutdown is called before terminated.