Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make //compiler:grpc_java_plugin publicly visible again (1.22 backport) #5953

Merged
merged 2 commits into from
Jul 8, 2019
Merged

Make //compiler:grpc_java_plugin publicly visible again (1.22 backport) #5953

merged 2 commits into from
Jul 8, 2019

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jul 3, 2019

Backport of #5947 and #5952

CC @aaliddell

aaliddell and others added 2 commits July 3, 2019 15:08
@aaliddell @ejona86
Make //compiler:grpc_java_plugin publicly visible again
770cc4b 
Prior to 745aa0a, this target was
visible publicly.
@ejona86
bazel: Add comment for public protoc plugin
9e7f7bf 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to grpc#5942 and grpc#5947
@ejona86 ejona86 requested a review from dapengzhang0 July 3, 2019 22:10
@ejona86 ejona86 merged commit f891558 into grpc:v1.22.x Jul 8, 2019
@ejona86 ejona86 deleted the backport-bazel-compiler-public-1.22 branch July 8, 2019 23:41
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees

@dapengzhang0 dapengzhang0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ejona86 @dapengzhang0 @aaliddell