Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make //compiler:grpc_java_plugin publicly visible again #5947

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Make //compiler:grpc_java_plugin publicly visible again #5947

merged 1 commit into from
Jul 3, 2019

Conversation

aaliddell
Copy link
Contributor

Fixes #5942

Prior to 745aa0a, this target was visible publicly and is useful for external projects that depend on the protoc plugin.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@aaliddell
Make //compiler:grpc_java_plugin publicly visible again
889dc4d 
Prior to 745aa0a, this target was
visible publicly.
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@aaliddell
Copy link
Contributor Author

CLA done

@dapengzhang0 dapengzhang0 mentioned this pull request Jul 3, 2019
Merged
@ejona86
Copy link
Member

ejona86 commented Jul 3, 2019

I want to discourage using this target. It was necessary to be exposed before because it was referenced by every usage of our own java_grpc_library. With the changes to java_grpc_library that's no longer the case.

I didn't see this PR before creating #5952

@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 3, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 3, 2019
ejona86
ejona86 approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a followup in #5952 to add a comment.

ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jul 3, 2019
@ejona86
bazel: Add comment for public protoc plugin
00873e7 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to grpc#5942 and grpc#5947
@ejona86 ejona86 merged commit f67aa4e into grpc:master Jul 3, 2019
@dapengzhang0
Copy link
Member

@aaliddell Thank you for filing and fixing the issue.

ejona86 added a commit that referenced this pull request Jul 3, 2019
@ejona86
bazel: Add comment for public protoc plugin
46ef515 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to #5942 and #5947
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jul 3, 2019
@ejona86
bazel: Add comment for public protoc plugin
9e7f7bf 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to grpc#5942 and grpc#5947
@ejona86 ejona86 mentioned this pull request Jul 3, 2019
Merged
ejona86 added a commit to ejona86/grpc-java that referenced this pull request Jul 3, 2019
@ejona86
bazel: Add comment for public protoc plugin
052d94a 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to grpc#5942 and grpc#5947
@ejona86 ejona86 mentioned this pull request Jul 3, 2019
Merged
ejona86 added a commit that referenced this pull request Jul 8, 2019
@ejona86
bazel: Add comment for public protoc plugin
9033efa 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to #5942 and #5947
ejona86 added a commit that referenced this pull request Jul 8, 2019
@ejona86
bazel: Add comment for public protoc plugin
f891558 
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.

Related to #5942 and #5947
@lock lock bot locked as resolved and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

//compiler:grpc_java_plugin no longer visible
5 participants
@aaliddell @thelinuxfoundation @ejona86 @dapengzhang0 @grpc-kokoro