alts: fix server hang #5900
Merged
alts: fix server hang #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jiangtaoli2016 it would be super helpful if there was a mock nanny handshaker so we could test the client and server together. It's pretty painful to test this internally, but then make the changes externally. |
|
@carl-mastrangelo We have fake handshaker service in gRPC c++ (grpc/test/core/tsi/alts/fake_handshaker/) used by envoy. Can grpc-java use this by running fake handshaker as a separate binary? Or we have to write a fake handshaker in Java. |
|
@jiangtaoli2016 can it be used in a bazel rule? we could make one here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5893 which causes a server side hang. This is a hack.