Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: (backport) make newNameResolver() change backward compatible for callers. #5564

Merged
merged 1 commit into from Apr 9, 2019
Merged

core: (backport) make newNameResolver() change backward compatible for callers. #5564

merged 1 commit into from Apr 9, 2019

Conversation

zhangkun83
Copy link
Contributor

@zhangkun83 zhangkun83 commented Apr 8, 2019 •
edited

We assumed that we were the only caller. Turns out there are
forwarding NameResolver too. Implementing the old override will give
them time to migrate to the new API.

(Backport of #5560)

@zhangkun83
core: make newNameResolver() change backward compatible for callers. (g…
80e9d81 
…rpc#5560)

We assumed that we were the only caller.  Turns out there are
forwarding NameResolver too.  Implementing the old override will give
them time to migrate to the new API.

Resolves grpc#5556
@zhangkun83 zhangkun83 requested a review from ejona86 April 8, 2019 23:13
@zhangkun83 zhangkun83 merged commit 7f3fa9b into grpc:v1.20.x Apr 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhangkun83 @ejona86