Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert " core: deprecate NR.L and add NR.Results " #5517

Merged
merged 1 commit into from Mar 29, 2019

Conversation

zhangkun83
Copy link
Contributor

This reverts commit f4a31ec.

This change is part of a series of unfinished API changes and refactors for Service Config Error Handling. It by its own should not go into the release.

Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapengzhang0
Copy link
Member

Why master branch not v1.20.x?

@zhangkun83 zhangkun83 closed this Mar 29, 2019
@zhangkun83 zhangkun83 reopened this Mar 29, 2019
@zhangkun83 zhangkun83 changed the base branch from master to v1.20.x March 29, 2019 00:33
@zhangkun83
Copy link
Contributor Author

@dapengzhang0 Thanks for the catch!

@zhangkun83 zhangkun83 merged commit 10d920a into grpc:v1.20.x Mar 29, 2019
@zhangkun83 zhangkun83 deleted the revert_nr_change_on_1.20.x branch March 29, 2019 00:35
@lock lock bot locked as resolved and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants