Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarks: Ensure ELGs used by TransportBenchmark.NETTY_LOCAL are shutdown #5506

Merged
merged 1 commit into from Mar 26, 2019
Merged

benchmarks: Ensure ELGs used by TransportBenchmark.NETTY_LOCAL are shutdown #5506

merged 1 commit into from Mar 26, 2019

Conversation

njhill
Copy link
Contributor

@njhill njhill commented Mar 26, 2019

This was an omission from #5492, sorry! Without it there are some ugly warnings in the log.

@njhill
Ensure ELGs used by TransportBenchmark.NETTY_LOCAL are shutdown
5635097 
This was an omission from grpc#5492, sorry! Without it there are some ugly warnings in the log.
@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 26, 2019
@dapengzhang0 dapengzhang0 added this to the 1.20 milestone Mar 26, 2019
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 26, 2019
@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 26, 2019
carl-mastrangelo
carl-mastrangelo approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapengzhang0 dapengzhang0 merged commit a8c7381 into grpc:master Mar 26, 2019
@njhill njhill deleted the bench-close-elg branch March 26, 2019 23:37
@njhill njhill changed the title Ensure ELGs used by TransportBenchmark.NETTY_LOCAL are shutdown benchmarks: Ensure ELGs used by TransportBenchmark.NETTY_LOCAL are shutdown Mar 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carl-mastrangelo carl-mastrangelo carl-mastrangelo approved these changes

Assignees

@carl-mastrangelo carl-mastrangelo

Labels
kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@njhill @carl-mastrangelo @dapengzhang0 @grpc-kokoro