benchmarks: Use correct ELG type for TransportBenchmark NETTY_LOCAL test #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty LocalChannels are meant to be used with the DefaultEventLoopGroup, but the gRPC channel/server builders use NioEventLoopGroups by default.
carl-mastrangelo
approved these changes
Mar 23, 2019
creamsoup
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
@njhill merged, thank you! |
|
Thanks @creamsoup! and was good to meet you last week @carl-mastrangelo |
njhill
added a commit
to njhill/grpc-java
that referenced
this pull request
Mar 26, 2019
This was an omission from grpc#5492, sorry! Without it there are some ugly warnings in the log.
dapengzhang0
pushed a commit
that referenced
this pull request
Mar 26, 2019
…utdown This was an omission from #5492, sorry! Without it there are some ugly warnings in the log.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty
LocalChannels are meant to be used with theDefaultEventLoopGroup, but the gRPC channel/server builders useNioEventLoopGroups by default.