New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Mockito 2 #5484
Update to Mockito 2 #5484
Conversation
Working on the deprecation warnings as we speak. |
@TimvdLippe Thank you for your PR. Please ping me when it's ready for review. |
This will resolve #5319 |
@dapengzhang0 Ready 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks like this is causing failures during dexing in the android-interop test. I think that one may not be run during presubmit. https://source.cloud.google.com/results/invocations/dc18ac18-556a-4871-b5ce-78b07f783e9e/log
|
Seems need to remove the old Dexmaker dependency and add |
FYI this is the upstream issue: mockito/mockito#1511 It is related to usage of outdated Android tooling. Make sure you are running the latest version of the Android Gradle Plugin. |
@TimvdLippe, thanks for the link. That's helpful. So we need to upgrade to com.android.tools.build:gradle:3.3.2. Unfortunately that requires upgrading Gradle to 4.10, which means non-Android is impacted. But since we're on Gradle 4.9 now, it may not be too hard. I'm working on this. |
This is the public port of cl/238445847
Fixes #5319