Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alts: add ComputeEngineChannelBuilder #5473

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

jiangtaoli2016
Copy link
Contributor

@jiangtaoli2016 jiangtaoli2016 commented Mar 13, 2019

Add ComputeEngineChannelBuilder. This is similar to GoogleDefaultChannelBuilder, except that ComputeEngineChannelBuilder only runs on GCE and only fetches call credentials from metadata server.

@jiangtaoli2016 jiangtaoli2016 changed the title ALTS: add ComputeEngineChannelBuilder alts: add ComputeEngineChannelBuilder Mar 13, 2019
@jiangtaoli2016
Copy link
Contributor Author

Hold on review. Let me fix presubmit error first.

@ejona86
Copy link
Member

ejona86 commented Mar 13, 2019

@jiangtaoli2016, those don't look like failures with your code. Try to rebuild them. Although the linux_artifacts looks broken for an unrelated reason; rebuilding won't fix it (but you can ignore it for now).

@jiangtaoli2016
Copy link
Contributor Author

Thanks @ejona86 for quick review.
@apolcyn Could you start using this new channel builder in your staging test?

@jiangtaoli2016 jiangtaoli2016 merged commit b4af5ad into grpc:master Mar 13, 2019
@apolcyn
Copy link
Contributor

apolcyn commented Mar 13, 2019

Thanks for the quick turnaround on this. I'll update tests to start using this

@apolcyn
Copy link
Contributor

apolcyn commented Mar 13, 2019

Actually for tests, can we follow up this PR to add support for using this new channel builder in the interop client? (probably around https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/TestServiceClient.java#L372)

@jiangtaoli2016
Copy link
Contributor Author

I forgot about that. Let me update the interop client with a new customCredentialTypes = "compute_engine_credentials" on Java side. @apolcyn can you update the python script with this new type after I submit java PR?

@apolcyn
Copy link
Contributor

apolcyn commented Mar 13, 2019

yeah, I can update tests once that's in

@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants