Bazel services + grpc_proto dependency #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
@perezd Thank you for you PR. Please follow go/cla for googlers to sign up CLA. Thanks. |
|
@dapengzhang0 Looks like I should be good? |
ejona86
approved these changes
Mar 6, 2019
carl-mastrangelo
pushed a commit
to grpc/grpc-proto
that referenced
this pull request
Mar 8, 2019
gRPC still makes use of it currently: grpc/grpc-java#5384
|
OK I've updated the commit now that the dependent change is accessible publicly. |
ejona86
approved these changes
Mar 11, 2019
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
|
@perezd, take a look at the Bazel failure. It looks legitimate. |
dapengzhang0
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got tired of waiting on #5184, so I forked and also did the integration with grpc-proto.
This PR should not be merged until grpc/grpc-proto#44 has been merged, as we depend on the newly added java proto rules.
Manually tested, everything builds.