Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Mockito dependency to version 2 #5319

Closed
suztomo opened this issue Feb 4, 2019 · 2 comments · Fixed by #5484
Closed

Upgrade Mockito dependency to version 2 #5319

suztomo opened this issue Feb 4, 2019 · 2 comments · Fixed by #5484
Milestone

Comments

@suztomo
Copy link
Contributor

suztomo commented Feb 4, 2019

Please answer these questions before submitting your issue.

What version of gRPC are you using?

io.grpc:grpc-testing:1.17.1

What did you expect to see?

To use Mockito version 2.

As of now grpc-java project uses mockito 1.9.X. The last release of 1.9.X is 1.9.10 in 2014.

mockito: 'org.mockito:mockito-core:1.9.5',

Would you upgrade the dependency to mockito 2.24.0?
Mockito upgrade guilde from 1.10 to 2.X

Background

I'm trying to clean up grpc-related conflicting/outdated dependencies. (Example spring-cloud/spring-cloud-sleuth#1186)

@carl-mastrangelo
Copy link
Contributor

In progress in #5219

We can't use 2 yet, as the dependency is not available yet inside.

@suztomo
Copy link
Contributor Author

suztomo commented Feb 4, 2019

Thank you for response. I'm in no hurry. I will check the status again later (Maybe in April)

@carl-mastrangelo carl-mastrangelo added this to the Unscheduled milestone Feb 4, 2019
dapengzhang0 pushed a commit that referenced this issue Mar 19, 2019
This is the public port of cl/238445847

Fixes #5319
@ejona86 ejona86 modified the milestones: Unscheduled, 1.20 Apr 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants