Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf 3.23 is incompatible, so can't upgrade #10202

Closed
ejona86 opened this issue May 18, 2023 · 3 comments
Closed

Protobuf 3.23 is incompatible, so can't upgrade #10202

ejona86 opened this issue May 18, 2023 · 3 comments

Comments

@ejona86
Copy link
Member

ejona86 commented May 18, 2023

Protobuf 3.23 appears to be incompatible[1] with Protobuf 3.22. If we upgrade, users won't be able to upgrade gRPC.

gRPC 1.55 is the first version that used 3.22, so I think the best thing is for us to revert, in the released version, to the previous version we were using, which was 3.21.7.

protocolbuffers/protobuf#11986

@ejona86
Copy link
Member Author

ejona86 commented May 18, 2023

(On the plus side, we still haven't been able to get C++ compilation of our plugin working. #10048 We upgraded Java without upgrading C++. Reverting to the older version "fixes" the misalignment.)

@ejona86
Copy link
Member Author

ejona86 commented May 18, 2023

The point of the downgrade is to allow our downstream to upgrade to 3.23 as needed.

@ejona86
Copy link
Member Author

ejona86 commented May 18, 2023

I mixed up the incompatibility. The incompat is if you use a new codegen with old runtime. There's no way that could work; codegen can choose to use new features of the runtime. That's the same as in grpc.

@ejona86 ejona86 closed this as completed May 18, 2023
labianchin added a commit to spotify/dbeam that referenced this issue Jul 27, 2023
Because of issues in Dataflow and incompatibilities reported at grpc/grpc-java#10202
labianchin added a commit to spotify/dbeam that referenced this issue Jul 27, 2023
Because of issues in Dataflow and incompatibilities reported at grpc/grpc-java#10202
labianchin added a commit to spotify/dbeam that referenced this issue Jul 27, 2023
Because of issues in Dataflow and incompatibilities reported at grpc/grpc-java#10202
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant