binarylog: Account for key in metadata truncation #5851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
requested changes
Dec 9, 2022
gcp/observability/logging_test.go
Outdated
| ClientRPCEvents: []clientRPCEvents{ | ||
| { | ||
| Methods: []string{"*"}, | ||
| MaxMetadataBytes: 6, |
There was a problem hiding this comment.
This would be slightly nicer as:
const mdValue = "value"
...
MaxMetadataBytes: len(mdValue) + 1,
...There was a problem hiding this comment.
Ah, nice suggestion. Switched.
zasweq
changed the title
dfawley
approved these changes
Dec 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds accounting for the key bytes in metadata truncation, whereas previously it was not accounting for the key, just the value. This makes it consistent with other languages accounting, which is the length of key + value.
The added test fails on master (logs the metadata) but works (doesn't log the metadata) with my fix.
RELEASE NOTES: N/A