Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

o11y: /s/m specified in method string should error during validation, s/m should match calls to /s/m #5848

Closed
zasweq opened this issue Dec 7, 2022 · 1 comment
Closed

o11y: /s/m specified in method string should error during validation, s/m should match calls to /s/m #5848

zasweq opened this issue Dec 7, 2022 · 1 comment
Assignees
@zasweq
Labels
P2 Type: Bug
Milestone
1.52 Release

Comments

@zasweq
Copy link
Contributor

zasweq commented Dec 7, 2022

Right now, the observability package accepts a /s/m string in method for configuration. This should error at validation. Also, s/m specified in the config should match to RPC calls to /s/m, which it currently does not.
@zasweq zasweq self-assigned this Dec 7, 2022
@zasweq zasweq added the P2 label Dec 7, 2022
@zasweq zasweq added this to the 1.52 Release milestone Dec 7, 2022
@zasweq
Copy link
Contributor Author

zasweq commented Jan 31, 2023

Fixed by #5951.

@zasweq zasweq closed this as completed Jan 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zasweq zasweq

Labels
P2 Type: Bug
Projects
None yet
Milestone
1.52 Release
Development

No branches or pull requests
1 participant
@zasweq