Cap min and max ring size to 4K #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Nov 18, 2022
dfawley
reviewed
Dec 9, 2022
Comment on lines
60
to
62
| if cfg.MinRingSize > cfg.MaxRingSize { | ||
| return nil, fmt.Errorf("min %v is greater than max %v", cfg.MinRingSize, cfg.MaxRingSize) | ||
| } |
There was a problem hiding this comment.
Should this check be done first? Otherwise it passes if Min > Max > MaxCap. Or is that okay?
There was a problem hiding this comment.
Because MaxCap is supposed to clamp min and max, I don't see a benefit of failing (beyond catching weird configuration). The client is still able to make use of such data sensibly, because of the clamp, so it seems overly fragile to fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the settings described in grpc/proposal#338.
Note: a configuration option (preferable taking the form of a dial option, but possibly using a global) is left as a TODO.
Side note: this will mitigate internal issue b/255207468
cc @easwars
RELEASE NOTES:
max_ring_sizeto reduce possibility of OOMs