Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Compression Asymmetry #5792

Closed
hshamji opened this issue Nov 14, 2022 · 3 comments · Fixed by #5744
Closed

Server Compression Asymmetry #5792

hshamji opened this issue Nov 14, 2022 · 3 comments · Fixed by #5744
Labels
P2 Type: Feature New features or improvements in behavior

Comments

@hshamji
Copy link

hshamji commented Nov 14, 2022

Please see the FAQ in our main README.md before submitting your issue.

Use case(s) - what problem will this feature solve?

This grpc compression document describes compression asymmetry. When attempting to set grpc-encoding in the response metadata, I found the header not getting propagated since it is reserved. This behavior is confirmed here, excerpting:

Server-side, registered compressors will be used automatically to decode request messages and encode the responses. Servers currently always respond using the same compression method specified by the client.

It would be great to have functionality to vary the request vs. response compression for a server.

For more detail, I'm proxying compressed requests (without decompressing/recompressing) to backends that themselves provide asymmetric request-responses.

Proposed Solution

Allow for manual setting of grpc-encoding (and possibly other) headers to allow for explicit control over request/response encoding.

Alternatives Considered

Additional Context

@hshamji hshamji added the Type: Feature New features or improvements in behavior label Nov 14, 2022
@hshamji
Copy link
Author

hshamji commented Nov 15, 2022

Would be happy to work on this if it is deemed worthwhile/appropriate. And if so, any pointers, suggestions, edge-cases would also be most welcome.

@dfawley
Copy link
Member

dfawley commented Nov 23, 2022

#5744 may add exactly what you want here.

@hshamji
Copy link
Author

hshamji commented Nov 28, 2022

@dfawley that's it! What timing! TY TY

@dfawley dfawley added the P2 label Nov 28, 2022
@dfawley dfawley removed their assignment Nov 28, 2022
dfawley pushed a commit that referenced this issue Jan 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants