Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp/observability: add started rpc metric #5768

Merged
merged 2 commits into from Nov 4, 2022

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Nov 4, 2022

GoLang was missing the started rpc metric present in C-core and Java. This was just added to go opencensus. This PR adds it to our o11y plugin.

RELEASE NOTES:

  • o11y: Added started rpcs metric

@zasweq zasweq requested a review from dfawley November 4, 2022 20:27
@zasweq zasweq added this to the 1.51 Release milestone Nov 4, 2022
@dfawley
Copy link
Contributor

dfawley commented Nov 4, 2022

Looks like this needs a go mod tidy

@dfawley dfawley assigned zasweq and unassigned dfawley Nov 4, 2022
@zasweq zasweq merged commit 32f969e into grpc:master Nov 4, 2022
1 check passed
@dfawley dfawley changed the title o11y: Added started rpc metric in o11y plugin gcp/observability: add started rpc metric Nov 18, 2022
@grpc grpc deleted a comment from Facecasino Nov 21, 2022
jronak pushed a commit to jronak/grpc-go that referenced this pull request Nov 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants