gcp/observability: filter logging from cloud ops endpoints calls #5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Nov 3, 2022
There was a problem hiding this comment.
Can you please add a unit test that covers these methods and expects no logging?
You should be able to use the native gRPC API to make it easy to set the method without needing the protos: https://pkg.go.dev/google.golang.org/grpc#ClientConn.Invoke
|
Added a unit test. Thanks. |
dfawley
changed the title
dfawley
approved these changes
Nov 7, 2022
gcp/observability/logging_test.go
Outdated
| // calls, as they should be filtered out. | ||
| fle.mu.Lock() | ||
| if len(fle.entries) != 0 { | ||
| fle.mu.Unlock() |
There was a problem hiding this comment.
Nit: use a defer instead to avoid the two unlocks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering of logging from the calls to cloud ops endpoints was missed in the new Observability config iteration. This adds it back. Decided not to info log in this scenario to avoid std out log spam.
RELEASE NOTES: N/A