metadata: add ValueFromIncomingContext to more efficiently retrieve a single value #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
FromIncomingContext creates a copy of md every time. So even if you need a single header value you will get a value and an overhead for this. Many interceptors and user code doesn't need all values at a time.
horpto
force-pushed
the
value-from-incoming-context
branch
from
18ee8a3
to
e73bfc2
Compare
zasweq
approved these changes
Sep 7, 2022
|
@dfawley for a second reviewer. |
zasweq
changed the title
dfawley
reviewed
Sep 7, 2022
dfawley
approved these changes
Sep 7, 2022
dfawley
changed the title
|
Thank you for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromIncomingContext creates a copy of md every time.
So even if you need a single header value you will get a value and an overhead for this.
Many interceptors and user code doesn't need all values at a time.
I'd like also to add a helper to just check key existence.
RELEASE NOTES:
ValueFromIncomingContextto more efficiently retrieve a single value