gcp/observability: Add support for custom tags #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Aug 10, 2022
gcp/observability/config.go
Outdated
| @@ -41,6 +39,69 @@ const ( | |||
|
|
|||
| var logFilterPatternRegexp = regexp.MustCompile(logFilterPatternRegexpStr) | |||
|
|
|||
| // LogFilter represents a method logging configuration. | |||
| type LogFilter struct { | |||
There was a problem hiding this comment.
This type should not be exported, right? Same below.
gcp/observability/config.go
Outdated
| // configuration is required for tracing/metrics/logging to function. This | ||
| // config captures the most common knobs for gRPC users. It's always possible to | ||
| // override with explicit config in code. | ||
| type ObvConfig struct { |
There was a problem hiding this comment.
Just config? Or maybe jsonConfig?
gcp/observability/opencensus.go
Outdated
| @@ -38,26 +37,59 @@ var ( | |||
| defaultMetricsReportingInterval = time.Second * 30 | |||
| ) | |||
|
|
|||
| func convertTagsToMonitoringLabels(tags map[string]string) *stackdriver.Labels { | |||
There was a problem hiding this comment.
Drop the convert; it's cleaner?
zasweq
commented
Aug 11, 2022
gcp/observability/config.go
Outdated
| // configuration is required for tracing/metrics/logging to function. This | ||
| // config captures the most common knobs for gRPC users. It's always possible to | ||
| // override with explicit config in code. | ||
| type ObvConfig struct { |
gcp/observability/opencensus.go
Outdated
| @@ -38,26 +37,59 @@ var ( | |||
| defaultMetricsReportingInterval = time.Second * 30 | |||
| ) | |||
|
|
|||
| func convertTagsToMonitoringLabels(tags map[string]string) *stackdriver.Labels { | |||
dfawley
approved these changes
Aug 11, 2022
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for custom tags in Observability for Metrics, Tracing, and Logging. Custom tags are defined in the configuration and attached to emitted Logs, Traces, and Metrics. Currently there is no way to test this E2E, so the best we can do is verify the config passed into the Tracing and Metrics exporter has the correct custom tags present. Also, since this added a new field to the configuration, we decided it would be better if we got rid of the implementation detail of representation the configuration with a proto file, which I switched to an internal struct.
This PR does the following:
RELEASE NOTES: