grpc: prevent a nil stats handler from causing a panic #5543

dfawley · 2022-07-28T20:57:52Z

RELEASE NOTES:

Fix a panic caused by passing a nil stats handler to grpc.WithStatsHandler or grpc.StatsHandler

dialoptions.go

server.go

easwars · 2022-07-28T23:38:19Z

Hope you have better luck with the tests !!

dfawley · 2022-07-29T16:53:47Z

Hope you have better luck with the tests !!

Oops, the failures are caused by this change - we had a test that was unnecessarily adding a nil stats handler in order to test something unrelated.

dfawley added the Type: Bug label Jul 28, 2022

dfawley added this to the 1.49 Release milestone Jul 28, 2022

dfawley requested a review from easwars July 28, 2022 20:57

dfawley assigned easwars Jul 28, 2022

easwars reviewed Jul 28, 2022

View reviewed changes

dialoptions.go Show resolved Hide resolved

server.go Show resolved Hide resolved

easwars assigned dfawley and unassigned easwars Jul 28, 2022

easwars approved these changes Jul 28, 2022

View reviewed changes

dfawley added 3 commits July 29, 2022 16:46

client: prevent a nil stats handler from causing a panic

13efb0f

fix server too

b4efd2d

log error

23432ac

dfawley force-pushed the nil_stats_handler branch from ac867f0 to 23432ac Compare July 29, 2022 16:46

fix test

af4c734

dfawley merged commit 02f1a7a into grpc:master Jul 29, 2022
1 check passed

dfawley added the Cherry Pick label Jul 29, 2022

dfawley deleted the nil_stats_handler branch July 29, 2022 17:45

moul-bot mentioned this pull request Oct 7, 2022

chore(deps): bump google.golang.org/grpc from 1.38.0 to 1.50.0 moul/depviz#581

Closed

moul-bot mentioned this pull request Oct 17, 2022

chore(deps): bump google.golang.org/grpc from 1.38.0 to 1.50.1 moul/depviz#586

Closed

dfawley removed the Cherry Pick label Jan 24, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023

Provide feedback