-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab comment from proto file, similar to protoc-gen-go #5540
Grab comment from proto file, similar to protoc-gen-go #5540
Conversation
This code was copied from the main protoc-gen-go code
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
The |
Changes to the code generator will require that you re-run |
I ran |
Would you mind downloading that version and making sure it gets run instead?
|
I don't know why those tests are failing, they seem unrelated to my changes as far as I can tell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can merge once the nits are taken care of.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
I'm not sure what else needs to be done? |
Thank you for the PR !! |
Now that this is fixed, is there going to be a new version tag for protoc-gen-go-grpc? |
Yes, we will get that out soonish. Filed #6060 to track. |
Hi @andremarianiello, you should find the fix included in our latest release of proto-gen-go-gRPC. Please feel free to reach out if there are any concerns. |
Adding initial code. grabs the header comment from the FileDescriptor
This code was copied from the main protoc-gen-go code
Attempts to address #5530
It's quick and dirty, but I'm going people who know better about the project can suggest a better way.
RELEASE NOTES: n/a