Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdsclient: handle empty authority in new style resource names #5488

Merged
merged 1 commit into from Jul 12, 2022
Merged

xdsclient: handle empty authority in new style resource names #5488

merged 1 commit into from Jul 12, 2022

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jul 8, 2022 •
edited

Fixes #5487

RELEASE NOTES:

  • xds: request correct resource name from management server when user specifies a new style resource name with empty authority

@easwars easwars requested a review from dfawley July 8, 2022 20:04
@easwars easwars added this to the 1.48 Release milestone Jul 8, 2022
@easwars
Copy link
Contributor Author

easwars commented Jul 8, 2022

I'm not sure if we need this fix to be part of the upcoming release (depends whether we have people using the new style names already). Marked it for 1.48 anyways, we can change it later if we decide otherwise.

dfawley
dfawley approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xds: xdsclient handles empty authority in new style resource names

Can you clarify this a little bit? It reads more like a feature addition than a bug fix.

@dfawley dfawley assigned easwars and unassigned dfawley Jul 12, 2022
@dfawley dfawley modified the milestones: 1.48 Release, 1.49 Release Jul 12, 2022
@easwars
Copy link
Contributor Author

easwars commented Jul 12, 2022

Can you clarify this a little bit? It reads more like a feature addition than a bug fix.

Done. Thanks

@easwars easwars merged commit 5e15eac into grpc:master Jul 12, 2022
@easwars easwars deleted the empty_authority branch July 12, 2022 21:12
@moul-bot moul-bot mentioned this pull request Oct 7, 2022
Closed
@moul-bot moul-bot mentioned this pull request Oct 17, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels
Type: Bug
Projects
None yet
Milestone
1.49 Release
Development

Successfully merging this pull request may close these issues.

xdsclient: handle empty authority in new style resource names correctly
2 participants
@easwars @dfawley