rls: use UNAVAILABLE instead of status from control plane #5400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Jun 3, 2022
balancer/rls/picker.go
Outdated
| // the status code sent by the control plane. Propagating the status | ||
| // message received from the control plane is still fine, as it could be | ||
| // useful for debugging purposes. | ||
| return p.useDefaultPickIfPossible(info, status.Error(codes.Unavailable, st.Error())) |
There was a problem hiding this comment.
Should we prefix the error string with a message indicating the source of the error?
dfawley
added
Type: Bug
and removed
Type: Behavior Change
dfawley
approved these changes
Jun 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: