transport: add HTTP status and grpc status to response if POST check fails #5364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
added
Type: Bug
Type: Behavior Change
dfawley
reviewed
May 18, 2022
dfawley
approved these changes
May 19, 2022
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2881. This switches what was originally there (RST Stream) to a full HTTP Response with desired HTTP and gRPC status. Both of these abide to language of issue "grpc-go should fail RPCs if the method is anything but POST". This also abides to Eric's point of reopening this issue, which is that the response should be "An HTTP response with HTTP status code".
RELEASE NOTES: