Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/resolver: use correct resource name in log message #5357

Merged
merged 2 commits into from May 16, 2022

Conversation

easwars
Copy link
Contributor

@easwars easwars commented May 16, 2022

With federation support, resourceName could be different from the user's dial target.

RELEASE NOTES: none

@easwars easwars added the Type: Internal Cleanup Refactors, etc label May 16, 2022
@easwars easwars added this to the 1.47 Release milestone May 16, 2022
@easwars easwars requested a review from menghanl May 16, 2022 16:25
@easwars
Copy link
Contributor Author

easwars commented May 16, 2022

@menghanl : Please don't review this yet. Looks like I need to make a few more changes. Will let you know once this is ready to be looked at.

@easwars
Copy link
Contributor Author

easwars commented May 16, 2022

@menghanl : It it ready now. Thanks.

@menghanl menghanl assigned easwars and unassigned menghanl May 16, 2022
@easwars easwars merged commit d9b952b into grpc:master May 16, 2022
@easwars easwars deleted the xds_resolver_minor_nits branch May 16, 2022 21:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants