Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmp should not be used outside testing packages #5353

Closed
zasweq opened this issue May 13, 2022 · 1 comment
Closed

cmp should not be used outside testing packages #5353

zasweq opened this issue May 13, 2022 · 1 comment
Assignees
@zasweq
Labels
fixit Type: Bug
Milestone
1.47 Release

Comments

@zasweq
Copy link
Contributor

zasweq commented May 13, 2022

#5299 had a cmp package imported in a non testing file. This is not allowed.
@zasweq zasweq self-assigned this May 13, 2022
@zasweq zasweq added this to the 1.47 Release milestone May 13, 2022
@zasweq zasweq added the fixit label May 16, 2022
This was referenced May 16, 2022
Closed
Merged
@zasweq
Copy link
Contributor Author

zasweq commented May 24, 2022

Fixed by #5370.

@zasweq zasweq closed this as completed May 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zasweq zasweq

Labels
fixit Type: Bug
Projects
None yet
Milestone
1.47 Release
Development

No branches or pull requests
1 participant
@zasweq