xds/priority: start the init timer when a child switch to Connecting from non-transient-failure state #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… child switch to Connecting from non-transient-failure state See grpc/proposal#296 for context. After this change, priority will restart the failover timer when a child reports Connecting, if that child hasn't reported TF more recently than it reported Ready or Idle. Also changed the priority policy to always call the centralized function `syncPriority` to handle child switching.
dfawley
approved these changes
May 6, 2022
| @@ -55,6 +56,9 @@ var ( | |||
| // - For any of the following cases: | |||
| // - If balancer is not started (not built), this is either a new child | |||
There was a problem hiding this comment.
Fix indent here? (Remove tab?) Or is this just a github problem??
There was a problem hiding this comment.
Done. Seems there were tabs??? Who uses tabs???
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See grpc/proposal#296 for context.
After this change, priority will restart the failover timer when a child
reports Connecting, if that child hasn't reported TF more recently than
it reported Ready or Idle.
Also changed the priority policy to always call the centralized function
syncPriorityto handle child switching.RELEASE NOTES: