Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: always backoff between new streams even after successful stream #5280

Merged
merged 3 commits into from Apr 1, 2022

Conversation

dfawley
Copy link
Contributor

@dfawley dfawley commented Mar 29, 2022

Also: receiving from a stopped timer channel is unnecessary unless the timer is going to be reused via Reset.

RELEASE NOTES:

  • xds: the xds client will now apply a 1 second backoff before recreating ADS or LRS streams

@dfawley dfawley added this to the 1.46 Release milestone Mar 29, 2022
@dfawley dfawley requested a review from menghanl March 29, 2022 20:22
@menghanl menghanl assigned dfawley and unassigned menghanl Mar 29, 2022
@menghanl menghanl changed the title xdsclient: apply initial backoff even after successful stream xdsclient: always backoff between new xDS streams even after successful stream Mar 29, 2022
@menghanl menghanl changed the title xdsclient: always backoff between new xDS streams even after successful stream xdsclient: always backoff between new streams even after successful stream Mar 29, 2022
@dfawley dfawley merged commit 3cccf6a into grpc:master Apr 1, 2022
@dfawley dfawley deleted the adsdelay branch April 1, 2022 17:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants