Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: minor cleanup in xdsclient bootstrap code #5195

Merged
merged 1 commit into from Feb 15, 2022
Merged

xds: minor cleanup in xdsclient bootstrap code #5195

merged 1 commit into from Feb 15, 2022

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Feb 15, 2022

Summary of changes:

  • Make testing only functions more explicit by using ForTesting suffix in their name
  • Make a testing only server option explicit by using the ForTesting suffix in its name
  • Clarify some comments, fix typos etc

RELEASE NOTES: none

@easwars easwars added the Type: Internal Cleanup Refactors, etc label Feb 15, 2022
@easwars easwars added this to the 1.45 Release milestone Feb 15, 2022
@menghanl menghanl assigned easwars and unassigned menghanl Feb 15, 2022
@easwars easwars merged commit ec717ca into grpc:master Feb 15, 2022
@easwars easwars deleted the bootstrap_minor_cleanup branch March 21, 2022 21:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.45 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@easwars @menghanl