Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Add support for metadataMatcher.invert #5150

Closed
zasweq opened this issue Jan 19, 2022 · 1 comment
Closed

xds: Add support for metadataMatcher.invert #5150

zasweq opened this issue Jan 19, 2022 · 1 comment
Assignees
@zasweq
Labels
Type: Feature
Milestone
1.47 Release

Comments

@zasweq
Copy link
Contributor

zasweq commented Jan 19, 2022

MetadataMatcher.invert is not supported in Go's RBAC implementation, as it was just recently added to the gRFC: https://github.com/grpc/proposal/pull/285/files. As of right now, MetadataMatcher is a no-op, which logically used to be equivalent to false.
@zasweq zasweq self-assigned this Jan 19, 2022
@menghanl menghanl mentioned this issue Mar 16, 2022
Closed
@zasweq zasweq mentioned this issue May 10, 2022
Merged
@zasweq zasweq added this to the 1.47 Release milestone May 16, 2022
@zasweq
Copy link
Contributor Author

zasweq commented May 17, 2022

Fixed by #5345.

@zasweq zasweq closed this as completed May 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zasweq zasweq

Labels
Type: Feature
Projects
None yet
Milestone
1.47 Release
Development

No branches or pull requests
2 participants
@dfawley @zasweq