Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attributes: document that some value types (e.g. maps) must implement Equal #5109

Merged
merged 1 commit into from Jan 6, 2022
Merged

attributes: document that some value types (e.g. maps) must implement Equal #5109

merged 1 commit into from Jan 6, 2022

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Jan 6, 2022

fixes #5101

RELEASE NOTES:

  • attributes: document that some value types (e.g. maps) must implement Equal

@menghanl menghanl added the Type: Documentation Documentation or examples label Jan 6, 2022
@menghanl menghanl added this to the 1.44 Release milestone Jan 6, 2022
@menghanl menghanl requested a review from dfawley January 6, 2022 22:21
@dfawley dfawley assigned menghanl and unassigned dfawley Jan 6, 2022
@menghanl menghanl merged commit 907a202 into grpc:master Jan 6, 2022
@menghanl menghanl deleted the attr_comp_doc branch January 6, 2022 23:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.44 Release
Development

Successfully merging this pull request may close these issues.

attributes: values must be comparable (not documented)
2 participants
@menghanl @dfawley