grpclog.DepthLoggerV2: Correct comment: formats like fmt.Println #5038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation comments stated that arguments were handled like fmt.Print, when they are actually handled like fmt.Println. For example, the "fallback" implementation in internal/grpclog/grpclog.go for InfoDepth calls Logger.Infoln.
menghanl
approved these changes
Dec 7, 2021
dfawley
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation comments stated that arguments were handled like
fmt.Print, when they are actually handled like fmt.Println. For
example, the "fallback" implementation in
internal/grpclog/grpclog.go for InfoDepth calls Logger.Infoln.
RELEASE NOTES: N/A