Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/bootstrap_config: add a string function to server config #5031

Merged
merged 2 commits into from Dec 2, 2021

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Dec 1, 2021

This string representation of the server config will be used as map
keys, so that xds client can be shared by authorities with the same
config.

Also exported a field so it can be set by tests.

RELEASE NOTES: N/A

…nction to server config

This string representation of the server config will be used as map
keys, so that xds client can be shared by authorities with the same
config.

Also exported a field so it can be set by tests.
//
// Note that it covers (almost) all the fields so the string can be used map
// keys. Except NodeProto because NodeProto isn't used by federation (and this
// is only used as key in federation).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the last line the comment:

// Except NodeProto because NodeProto isn't used by federation (and this
// is only used as key in federation)

You are saying it is not used by federation, but is used as a key in federation. Can you please clarify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment updated.

@easwars easwars assigned menghanl and unassigned easwars Dec 1, 2021
@menghanl menghanl force-pushed the bootstrap_config_export_field branch from fb4c518 to f74d780 Compare December 2, 2021 18:29
@menghanl menghanl merged commit f3bbd12 into grpc:master Dec 2, 2021
@menghanl menghanl deleted the bootstrap_config_export_field branch December 2, 2021 21:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants