Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pickfirst: check b.sc before calling Connect #4971

Merged
merged 1 commit into from Nov 11, 2021
Merged

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 10, 2021

Fixes #4965

RELEASE NOTES:

  • client: fix nil panic in rare race conditions with the pick first LB policy

@menghanl menghanl assigned dfawley and unassigned menghanl Nov 10, 2021
@dfawley dfawley merged commit 6a896a3 into grpc:master Nov 11, 2021
@dfawley dfawley deleted the pfnilcheck branch November 11, 2021 00:48
menghanl pushed a commit to menghanl/grpc-go that referenced this pull request Nov 30, 2021
menghanl added a commit that referenced this pull request Dec 1, 2021
- creds/google: add NewDefaultCredentialsWithOptions() to support custom per-RPC creds (#4767, #4830)
- pickfirst: check b.sc before calling Connect (#4971)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pickfirst balancer can cause a nil pointer deref panic due to data race
2 participants