grpc: stabilize WithConnectParams DialOption #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @easwars |
easwars
approved these changes
Nov 2, 2021
|
Assigning to @dfawley for second eyes. |
dfawley
reviewed
Nov 2, 2021
|
@menghanl any concerns or objections? |
hypnoglow
force-pushed
the
4461-stabilize-WithConnectParams
branch
from
e072b1c
to
62f3162
Compare
dfawley
approved these changes
Nov 3, 2021
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed per #4461, this change removes comments stating that WithConnectParams API is still experimental.
Please let me know if we need to adjust any commentary for this function or change anything else.
Closes #4461
RELEASE NOTES: