xds/federation: support populating resource template in xds-resolver #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is based on #4892. All new changes are in the last commit. |
menghanl
force-pushed
the
federation_target_parsing
branch
from
448cb60
to
cfba88f
Compare
easwars
reviewed
Nov 1, 2021
menghanl
force-pushed
the
federation_target_parsing
branch
from
85457ab
to
da6d4c7
Compare
|
This is rebased on master. But the commit history is lost. |
easwars
reviewed
Nov 3, 2021
menghanl
force-pushed
the
federation_target_parsing
branch
from
53a360b
to
40ab629
Compare
easwars
reviewed
Nov 4, 2021
Comment on lines
263
to
266
| tgt := target | ||
| if opts.target != nil { | ||
| tgt = *opts.target | ||
| } |
There was a problem hiding this comment.
This is a bit of magic where we get the target from a global var if not set in opts. This makes the tests harder to read since the reader will have to keep track of all this. Instead, could we just always pass a valid target from tests?
menghanl
force-pushed
the
federation_target_parsing
branch
from
6c8bf77
to
27f50c7
Compare
[federation_target_parsing] template populate [federation_target_parsing] default bootstrap for test client [federation_target_parsing] fixed resolver tests, new tests not added yet [federation_target_parsing] new tests [federation_target_parsing] fix test [federation_target_parsing] c1
menghanl
force-pushed
the
federation_target_parsing
branch
from
27f50c7
to
ec1a81f
Compare
easwars
approved these changes
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also handle percent encoding for new style resource names.
RELEASE NOTES: