Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: channel_creds other than insecure and google_default #4515

Closed
amenzhinsky opened this issue Jun 4, 2021 · 8 comments
Closed

xds: channel_creds other than insecure and google_default #4515

amenzhinsky opened this issue Jun 4, 2021 · 8 comments

Comments

@amenzhinsky
Copy link
Contributor

Is there a plan to add new types of channel creds, especially I'm interested in tls creds for control planes that use self-sined certificates or clients without system ca certificates bundle?

@menghanl
Copy link
Contributor

menghanl commented Jun 4, 2021

I'm assuming you are talking about the creds configuration in xds bootstrap file, right?

@dfawley do you know if there's something planned?

@dfawley
Copy link
Member

dfawley commented Jun 4, 2021

I'm not sure. @easwars, do you know about this?

@amenzhinsky
Copy link
Contributor Author

@menghanl yep

Ideally I'd like to have something like:

{
  "type": "tls",
  "cert": "PEM-ENCODED-CERT",
  "key": "PEM-ENCODED-KEY",
  "ca_cert": "PEM-ENCODED-CERT",
  "server_name": "override-server-name",
  "insecure": false
}

that would result in credentials.NewTLS(&tls.Config{...})

@dfawley
Copy link
Member

dfawley commented Jun 7, 2021

cc @sanjaypujare

Something like this would need to be designed as a cross-language feature, if it's not already in the works. Should we move this to grpc/grpc for follow-up?

@menghanl
Copy link
Contributor

menghanl commented Jun 7, 2021

This was mentioned in the first xDS gRFC where the bootstrap format is defined: https://github.com/grpc/proposal/blob/master/A27-xds-global-load-balancing.md#xdsclient-and-bootstrap-file

Initially, the only types of channel creds we support will be google_default and insecure. In the future, we will add a general-purpose mechanism for configuring arbitrary channel creds types with arbitrary configuration.

I don't think I've heard anything afterwards.
@markdroth Did we make any concrete plan? Is this something we will support soon?

@markdroth
Copy link
Member

Yes, this is absolutely something that we plan to do; we already have a design it. We'll be tackling this in Q3.

@dfawley
Copy link
Member

dfawley commented May 16, 2022

IIUC this was implemented in #5136

@dfawley dfawley closed this as completed May 16, 2022
@markdroth
Copy link
Member

I suspect this feature request was not just for the plugin system (which probably isn't a public API) but rather specifically for adding a way to configure TlsCreds with some arbitrary configuration instead of GoogleDefaultCreds. We have a design for that but have not yet implemented it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants